Patch to correct a little wording mistake



Hi all!

I reported quite a long time ago bug 414197: "Bad formulation in
notification string at disconnection".
(http://bugzilla.gnome.org/show_bug.cgi?id=414197)

It is about the sentence "The network connection has been disconnected."
that appears in a tooltip and is grammatically a nonsense. ;-) Not a big
deal, but easy to change to make GNOME look more "professionnal".

As I see you don't have time to deal with those stupid details, I made
some patches to correct that. There are 4: 2 for each
networkmanager-applet series (0.6.5 and 0.7), and with two flavours (you
may think of others, I guess).
- The first patches (applet.c.diff for 0.7 and
applet-dbus-devices.c.diff for 0.6.5) change the sentence to "The
network connection has been interrupted.", which is the same as the old
but with correct syntax.
- The second patches (*-2.diff) change it to "The network connection is
down."

Hope this can help, I just can't bear your great work be spoiled by a
little expression that pops up on my Desktop. Thanks for NM!


Milan

PS: Could you put me in CC, since I'm not subscribed to the list?
--- src/applet.c	2007-10-29 13:58:49.000000000 +0100
+++ ../../Desktop/applet.c	2007-10-29 14:14:35.000000000 +0100
@@ -2829,7 +2829,7 @@
 #ifdef ENABLE_NOTIFY
 		if (!synthetic)
 			nma_send_event_notification (applet, NOTIFY_URGENCY_NORMAL, _("Disconnected"),
-							    _("The network connection has been disconnected."),
+							    _("The network connection has been interrupted."),
 							    "nm-no-connection");
 #endif
 
--- src/applet.c	2007-10-29 13:58:49.000000000 +0100
+++ ../../Desktop/applet.c-2	2007-10-29 14:14:59.000000000 +0100
@@ -2829,7 +2829,7 @@
 #ifdef ENABLE_NOTIFY
 		if (!synthetic)
 			nma_send_event_notification (applet, NOTIFY_URGENCY_NORMAL, _("Disconnected"),
-							    _("The network connection has been disconnected."),
+							    _("The network connection is down."),
 							    "nm-no-connection");
 #endif
 
--- src/applet-dbus-devices.c	2007-04-19 20:01:13.000000000 +0200
+++ ../applet-dbus-devices.c	2007-10-29 14:06:44.000000000 +0100
@@ -957,7 +957,7 @@
 	if (GTK_WIDGET_VISIBLE (GTK_WIDGET (applet)))
 	{
 		nma_send_event_notification (applet, NOTIFY_URGENCY_NORMAL, _("Disconnected"),
-			_("The network connection has been disconnected."), "nm-no-connection");
+			_("The network connection has been interrupted."), "nm-no-connection");
 	}
 #endif
 }
--- src/applet-dbus-devices.c	2007-04-19 20:01:13.000000000 +0200
+++ ../applet-dbus-devices.c-2	2007-10-29 14:07:31.000000000 +0100
@@ -957,7 +957,7 @@
 	if (GTK_WIDGET_VISIBLE (GTK_WIDGET (applet)))
 	{
 		nma_send_event_notification (applet, NOTIFY_URGENCY_NORMAL, _("Disconnected"),
-			_("The network connection has been disconnected."), "nm-no-connection");
+			_("The network connection is down."), "nm-no-connection");
 	}
 #endif
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]