Re: [PATCH] return type of GetPower()/Device.Killswitch has changed from UINT32 to INT32



On Tue, 2007-10-23 at 01:13 +0200, Michael Biebl wrote:
> Hi,
> 
> in hal-0.5.10 the return type of the Device.Killswitch GetPower() method
> has changed from UINT32 to INT32. The attached patch fixes that for the
> NetworkManager-0.6 branch.

Ok, thanks... If you don't mind, could you rework the patch to accept
both UINT32 and INT32?  If the first dbus_message_get_args() call fails,
just try another one with the second type.  If that one fails, then the
whole call has failed.  If you don't get to it perhaps I can...

I also committed a fix to trunk that will only print out the error
message once; that's a candidate for backporting as well.

Thanks,
Dan




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]