Re: Phase2 patch



Hello.

On Sat, 2007-01-27 at 14:33, Volker Braun wrote:
> On Sat, 27 Jan 2007 09:10:57 -0500, Dan Williams wrote:
> > [...]The short answer is
> > that the UI bits are great, but we need to ensure backwards compat with
> > the libnm-util C ABI and the NM DBus API.  But I think I've got a handle
> > on that, and that it's possible, although ugly.
> 
> How about we abuse eap_type to preserve the ABI, and make the phase2
> option selectable by high bits a la
> 
> #define NM_EAP_METHOD_TTLS            0x00000040      /* EAP-TTLS */
> #define NM_PHASE2_AUTH_PAP            0x00010000
> 
> eap_type = NM_EAP_METHOD_TTLS | NM_PHASE2_AUTH_PAP;
> 
> It even makes some sense to put these together since they are
> logically very close.

Sounds like a solution for me. Still somewhat ugly, but would work and
preserve the ABI for the 0.6 branch.

I totally ignored the ABI/API problems on my initial patch. Sorry.

regards
Stefan Schmidt

Attachment: signature.asc
Description: Digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]