Re: crashing vpn properties (patch)

[Dan Williams <dcbw redhat com>]

On Mon, 2007-12-10 at 22:59 -0600, Casey Harkins wrote:
> Casey Harkins wrote:
> >> Actually, whenever anything stuffs stuff into that table it needs to
> >> g_strdup() the key.  See update_one_secret() and copy_hash().
> >> Otherwise, you'll leak the keys when freeing the hash.  So anything that
> >> uses NMSettingVPNProperties (like the properties dialogs) also need to
> >> g_strdup() the key.  I probably missed that when fixing up the VPN
> >> properties hash.
> >>
> > 
> > Makes sense. Attached is a patch fixing this for the openvpn properties 
> > dialog. I'll take a look at the other vpn plugins as well (I know vpnc 
> > was crashing in my limited testing as well).
> > 
> 
> And here's an untested patch for vpnc. A brief look at the pptp plugin 
> looks like it hasn't been converted for the new API.

Committed, thanks.

pptp hasn't been converted because we'd like it to unify the use of PPP
down to one set of code, not sure how that's going.  But it would
probably be good to convert it over to the new API just to get people
going before trying to share code.

Dan