crashing vpn properties (patch)



The crashes when working with vpn properties (not just openvpn) are the result of using g_free() as the key_destroy_func. The keys being used for the properties hash table are #define'ed constants and shouldn't be free'ed. Attached is a one-liner that should fix this.

This should resolve RH bug #320941.

-casey
Index: libnm-util/nm-setting-vpn-properties.c
===================================================================
--- libnm-util/nm-setting-vpn-properties.c	(revision 3160)
+++ libnm-util/nm-setting-vpn-properties.c	(working copy)
@@ -61,7 +61,7 @@
 {
 	g_object_set (NM_SETTING (self), "name", NM_SETTING_VPN_PROPERTIES_SETTING_NAME, NULL);
 
-	self->data = g_hash_table_new_full (g_str_hash, g_str_equal, g_free, nm_gvalue_destroy);
+	self->data = g_hash_table_new_full (g_str_hash, g_str_equal, NULL, nm_gvalue_destroy);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]