Re: two small openvpn fixes

[Casey Harkins <caseyharkins gmail com>]

Jon Escombe wrote:
> 5) Helper expects "ifconfig_remote" which isn't provided by a TAP connection.

Attached patch should make this optional from openvpn's perspective. I 
haven't tested it, but it looks like NM will just issue a warning if it 
the ptp address is unset. Let me know if it works for you. Maybe Dan can 
weigh in if there is any problem with a vpn connection not setting the 
PTP address.

-casey

Index: vpn-daemons/openvpn/src/nm-openvpn-service-openvpn-helper.c
===================================================================
--- vpn-daemons/openvpn/src/nm-openvpn-service-openvpn-helper.c	(revision 3160)
+++ vpn-daemons/openvpn/src/nm-openvpn-service-openvpn-helper.c	(working copy)
@@ -222,8 +222,6 @@
 	val = addr_to_gvalue (getenv ("ifconfig_remote"));
 	if (val)
 		g_hash_table_insert (config, NM_VPN_PLUGIN_IP4_CONFIG_PTP, val);
-	else
-		helper_failed (connection, "IP4 PTP Address");
 
 	/* Netmask */
 	val = addr_to_gvalue (getenv ("route_netmask_1"));