Hi everyone, I just tested the latest svn versions of NetworkManager (r2674) and nm-applet (r113) and it's the first time, that it actually worked for me! In earlier tests, NM mostly segfaulted right away. Even my proposed move of nm-vpn-properties to nm-applet was committed, which is great imho. So here come my questions/comments: 1.) nm-vpn-properties: Because of the move of nm-vpn-properties, the POTFILES.* have to be updated to keep "make distcheck" happy. Patches are trivial and attached. Please apply. 2.) dep on dhclient with extended options: dhcdbd is dead, NM now controls dhclient directly, where it passes the -x flag to dhclient. This is a Fedora specific patch to support that that option. My question now is, if NM can also work with a vanilla dhcp3-client or if this patch is mandatory. How do other distros than Fedora handle this, do they all have this patch against dhcp3? 3.) binaries in /etc/NetworkManager/callouts/ NM installs a binary /etc/NetworkManager/callouts/nm-dhcp-client.action. According to the FHS [1], this is not allowed. nm-dhcp-client.action should either be a shell script as wrapper around the real nm-dhcp-client or the callout directory should be moved to another directory (under /usr/lib e.g.). 4.) A bug I encountered: Everytime I restart NetworkManager, the vpn menu entries in nm-applet are added again and listed multiple times. Other than that, the new NM seems to work fine so far. I'm eager to test the new system wide configuration management and the fixed IP address support. Cheers, Michael [1] http://www.pathname.com/fhs/pub/fhs-2.3.html#ETCHOSTSPECIFICSYSTEMCONFIGURATION -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
Index: po/POTFILES.in =================================================================== --- po/POTFILES.in (Revision 2674) +++ po/POTFILES.in (Arbeitskopie) @@ -1,11 +1,9 @@ [encoding: UTF-8] # List of source files containing translatable strings. # Please keep this file sorted alphabetically. -gnome/vpn-properties/nm-vpn-properties.c -gnome/vpn-properties/nm-vpn-properties.glade +src/nm-ap-security-leap.c src/nm-ap-security-wep.c +src/nm-ap-security-wpa-eap.c src/nm-ap-security-wpa-psk.c src/nm-ap-security.c src/nm-netlink-monitor.c -src/nm-ap-security-wpa-eap.c -src/nm-ap-security-leap.c Index: po/POTFILES.skip =================================================================== --- po/POTFILES.skip (Revision 2674) +++ po/POTFILES.skip (Arbeitskopie) @@ -1,3 +1,4 @@ +examples/python/NetworkManager.py examples/python/systray/eggtrayicon.c vpn-daemons/openvpn/auth-dialog/gnome-two-password-dialog.c vpn-daemons/openvpn/auth-dialog/main.c
Index: po/POTFILES.in =================================================================== --- po/POTFILES.in (Revision 113) +++ po/POTFILES.in (Arbeitskopie) @@ -44,6 +44,8 @@ src/other-network-dialog.h src/passphrase-dialog.c src/passphrase-dialog.h +src/vpn-properties/nm-vpn-properties.c +src/vpn-properties/nm-vpn-properties.glade # src/vpn-connection.c # src/vpn-connection.h src/vpn-password-dialog.c
Attachment:
signature.asc
Description: OpenPGP digital signature