Re: [PATCH] Some fixes for trunk


On 8/7/07, Helmut Schaa <hschaa suse de> wrote:
> while porting KNetworkManager to NM 0.7 I found a few issues which need fixing
> in NM. Attached are three patches which apply cleanly against trunk.
> 1) allow_linking_with_cpp.patch:
> As the filename indicates this patch adds support for using libnm_util and
> libnm_glib from within C++.

I'll replace these with G_BEGIN_DECLS / G_END_DECLS (macros that
expand to exactly the same but will make editors not indent the whole
content of header file because of { }).

> 2) fix_segfault.patch:
> This patch fixes a segfault caused by some ssid being NULL. I don't know if it
> is desired to have ssid's being NULL but in current trunk using my ipw2200
> I've got a lot of these.

It's NULL for all hidden APs, looks good.

> 3) fix_memory_corruption.patch
> The most important one (it took hours to find the cause). Call to g_object_get
> writes a gint (4 byte) into the gint8 output buffer (1 byte) and thus
> overwrites some other data (in my case the last_seen property).

Nice catch. The proper fix would be to not write 4 bytes to that
pointer though, I'll commit a fix for that instead.

> Please have a look at the patches and commit to trunk.

Thanks! I'll commit all these changes shortly.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]