Re: D: Extending dict API to support split networking

[Dan Williams <dcbw redhat com>]

On Sat, 2006-10-28 at 23:31 +0200, Thomas Liebetraut wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> 
> Hi,
> 
> There is currently no way to map multiple routes as needed by split
> networks to the dict structure. As far as I've seen, there is also no
> way to add structs to the dictionary (not that dbus could not do it,
> there is just no easy nmu_dbus_add_dict_*() function for it).
> - From vpnc, I can get both, a netmask in the form of w.x.y.z/a and
> w.x.y.z/a.b.c.d without converting manually between the two forms.
> In what way should the dbus API be extended to provide the necessary
> functionality?

We could push those through as an array of strings, but that adds
parsing complexity to NM.  Ideally we could pass them through as a dict
entry of array of struct (uint32, uint32), but that gets complicated to
add to the dbus helpers.  This is one that needs more thought.

> If I'm not mistaken, the current code uses multiple dict entries that
> have the same key, which violates the dbus specification. Maybe there
> should be a way to avoid this?

You're right, it does.  And that's wrong, I didn't catch it the first
time around, and it was probably put into the plugin because the utility
functions for adding dicts weren't completed for structures.

So your suggestion of adding support to the dbus dict helpers for adding
an array of uint32s is probably a good one.  There already are helper
functions for adding byte and string arrays, doing one for uint32
shouldn't be too much work; maybe I'll add that this weekend.

Dan

> 
> Regards
> Thomas
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.3 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFFQ8wXxVmZpTAq4IgRAg2qAJ9xgqsgPQPBz0GQGNjiA1Q9qPPOBgCcDfu3
> 8DfalFyou1xunZI/Xy8WPyo=
> =vgyw
> -----END PGP SIGNATURE-----
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list