Re: [Patch] dict based vpnc plugin
- From: Dan Williams <dcbw redhat com>
- To: Thomas Liebetraut <thomas tommie-lie de>
- Cc: NetworkManager <networkmanager-list gnome org>
- Subject: Re: [Patch] dict based vpnc plugin
- Date: Wed, 01 Nov 2006 01:52:52 -0500
On Sat, 2006-10-28 at 21:13 +0200, Thomas Liebetraut wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> As first step, I ported NM's vpnc plugin to the newer dict API. It seems
> to work fine here when connecting to my university's network.
> I've attached a cvs diff from the vpn-daemons/ directory.
> I'd be glad if someone could have a look at it to verify that I've done
> everything right.
> Now as there are two plugins using the same communication API, maybe it
> would be a good idea to move the dbus/dict related stuff to a common
> source file in the vpn-daemons/ directory that can be used by all
> plugins beneath vpn-daemons/.
Right, though we should probably get the plugins using libnm-util like
the applet and NM do, then they wouldn't have to include the sources at
One quick note; your diff is in context diff format, which is hard to
follow for many people. Using 'cvs diff -u' is the best option, to
produce a 'unified' diff format which is much easier to read.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.3 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> -----END PGP SIGNATURE-----
> NetworkManager-list mailing list
> NetworkManager-list gnome org
] [Thread Prev