Re: [Patch] dict based vpnc plugin

[Dan Williams <dcbw redhat com>]

On Sat, 2006-10-28 at 21:13 +0200, Thomas Liebetraut wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> 
> Hi,
> 
> As first step, I ported NM's vpnc plugin to the newer dict API. It seems
> to work fine here when connecting to my university's network.
> I've attached a cvs diff from the vpn-daemons/ directory.
> I'd be glad if someone could have a look at it to verify that I've done
> everything right.
> Now as there are two plugins using the same communication API, maybe it
> would be a good idea to move the dbus/dict related stuff to a common
> source file in the vpn-daemons/ directory that can be used by all
> plugins beneath vpn-daemons/.

Right, though we should probably get the plugins using libnm-util like
the applet and NM do, then they wouldn't have to include the sources at
all.

One quick note; your diff is in context diff format, which is hard to
follow for many people.  Using 'cvs diff -u' is the best option, to
produce a 'unified' diff format which is much easier to read.

Thanks!
Dan

> Regards,
> Thomas
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.3 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFFQ6u9xVmZpTAq4IgRAo8oAJ92Xcj89KIHVjCJOpHXdJ0bPhe35wCgh3Vs
> 8m3dc+HgoLSMk5crpq2okBg=
> =6ria
> -----END PGP SIGNATURE-----
> _______________________________________________
> NetworkManager-list mailing list
> NetworkManager-list gnome org
> http://mail.gnome.org/mailman/listinfo/networkmanager-list