Re: [PATCH] Backend for Gentoo Linux with baselayout-1.12



Nice work,

On Fri, 2006-08-04 at 16:40 +0200, Shogun wrote:
> I just wrote a patch which enables NM to read configuration file for 
> Gentoo Linux with baselayout-1.12 (which has different format than before).

I thought the newer format had been around longer than that. Somebody
came on #networkmanager today wanting to use static configs on a Gentoo
box with base-layout-1.11.something and his net.example had the newer
format.

> Currently, my patch can parse file which are formatted as in 
> /etc/conf.d/net.example with long options:

> This patch MUST be improved to support spaces in the files, and the 
> configure script must have a test to check when apply it (or simply an 
> use-flag in the ebuild).

Your patch wouldn't apply against CVS HEAD so I created a new version of
the patch and opened a bug to track this:    
   http://bugzilla.gnome.org/show_bug.cgi?id=350101

----
Also, can anybody tell me the official line on indenting (tabs /2
spaces/ 4 spaces) and placement of the opening braces?
NetworkManagerGentoo.c is one of the many files suffering from quite a
mixture :-)

tOnY




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]