Re: [patch] making the applet stetic.

[Jonathan Blandford <jrb redhat com>]

Robert Love <rml novell com> writes:

> I'm not totally following the rationale why gtkrendercellprogressfoo is
> better.  Simply that it is (supposed) to look better embedded in menus?
> Is that really a good enough reason for all of the code?

It is supposed to look better for menus and treeviews.  'All that code'
is misleading because it should only be compiled if you are building it
against gtk+-2.4 .  If you have newer versions of GTK+, you should be
able to remove it from compilation altogether.  At some point[1], NM is
going to require some newer feature from GTK+, and we can drop it then.

> For what its worth, the gtkrendercell things look awful in Industrial
> and whatever Ubuntu uses, compared to Gtk Progress Bars.

Does it look better if you change the x/y thickness in those themes for
GtkCellView?  I just filed 308428 and 308429 for these issues.  There
really should be no reason a theme engine can't make these draw
basically identically.

> It also just looks generally uglier to me, but that is objective.

'objective' or 'subjective'? (-;  

I agree that the thick black-line looks bad with the progress renderer,
but the bevel looks equally awful.  This is clearly a GTK+ issue and I'm
raising it there.  I would prefer to use the right object in the right
place though, so we can fix it for all applications.

Thanks,
-Jonathan

[1] As is inevitable with all projects...