Re: [patch] making the applet stetic.

[Dan Williams <dcbw redhat com>]

On Mon, 2005-06-20 at 14:49 -0400, Jonathan Blandford wrote:
> Dan Williams <dcbw redhat com> writes:
> 
> > On Mon, 2005-06-20 at 13:37 -0400, Jonathan Blandford wrote:
> > > Robert Love <rml novell com> writes:
> > > There are a couple of other issues that you listed:
> > > 
> > > > 	- Follows the system theme.  The current Gtkcellrender thing
> > > > 	  is not correctly themed.
> > > 
> > > I'm not 100% sure what you mean by this?  Do you mean that it doesn't
> > > honor theme changes?  Or is it getting some things wrong.
> > 
> > The problem here was that the initial menu items were subclasses of the
> > GtkMenuItem and therefore, when the theme changed, they didn't pick up
> > the new GtkStyle due to inherent gtkrc (subclasses have a different
> > style path/name or whatever which means they don't match anything in the
> > gtkrc).  See:
> > 
> > http://bugzilla.gnome.org/show_bug.cgi?id=142417
> > 
> > The workarounds suggested by Owen either aren't sufficient or were just
> > plain ugly, since theme writers need to modify their theme rc files to
> > support what we are trying to do with the subclasses of GtkMenuItem.
> > Which sucks.
> 
> That problem will affect the progress bar too, though.  And it looked
> like you removed the subclasses already.  Is this still an issue?

You're right, I did kill them (I converted the subclasses to private
structs).  So I'm unsure how much of an issue it is...

Dan