Re: [patch] making the applet stetic.
- From: Dan Williams <dcbw redhat com>
- To: Robert Love <rml novell com>
- Cc: networkmanager-list gnome org
- Subject: Re: [patch] making the applet stetic.
- Date: Thu, 16 Jun 2005 14:49:18 -0400
On Thu, 2005-06-16 at 13:34 -0400, Robert Love wrote:
> As we all know, being stetic is of the utmost importance:
>
> http://primates.ximian.com/~peter/stetic.html
>
> The current NetworkManager applet is not as stetic as it deserves to be;
> it has potential, it dreams of a world in which it is the most beautiful
> applet ever, but it is not yet there.
>
> The progress bars immediately jump out as low-hanging fruit.
>
> The attached patch replaces the current gtkcellrenderprivate magic with
> Gtk Progress Bars--but not just any progress bars. Progress bars that
> are dynamically sized based on the font size. Beautiful, lovely, public
> progress bars.
>
> The benefits:
>
> - Follows the system theme. The current Gtkcellrender thing
> is not correctly themed.
> - Uses a public API instead of the private in-tree gtk code.
> - Nicer looking size.
> - Dynamically-sized based on the current language and font
> ascent, to five ascents long and one high. This elegant
> code is c/o Joey Shaw.
> - Net code reduction of -1532 lines, four files.
> - Oh, it is sooo stetic.
>
Applied, thanks. Brian also suggested making the progress bars not as
tall, so I've made them (ascent / 2).
Dan
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]