Re: [patch] making the applet stetic.



On Thu, 2005-06-16 at 14:49 -0400, Dan Williams wrote:

> Applied, thanks.  Brian also suggested making the progress bars not as
> tall, so I've made them (ascent / 2).

Thanks, Dan.

Well, I would take a bullet (or at least some sort of blunt flying
projectile) for my neighbor Brian, but I think that "ascent/2" is too
small.  Personally.  It is a personal thing.  Nothing against Brian, but
half is too small.

If "ascent" is too big, another option is to pass "-1" and have the
widget scaled to the size of the other widgets.  That might be a bit
smaller, depending on your font, but not as big as "ascent".

A patch doing this is attached.

If not, the comment needs to be adjusted. ;-)

	Robert Love

 menu-items.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Index: gnome/applet/menu-items.c
===================================================================
RCS file: /cvs/gnome/NetworkManager/gnome/applet/menu-items.c,v
retrieving revision 1.3
diff -u -u -r1.3 menu-items.c
--- gnome/applet/menu-items.c	16 Jun 2005 18:47:56 -0000	1.3
+++ gnome/applet/menu-items.c	16 Jun 2005 20:29:18 -0000
@@ -216,8 +216,8 @@
 	ascent = pango_font_metrics_get_ascent (metrics) * 1.5 / PANGO_SCALE;
 	pango_font_metrics_unref (metrics);
 
-	/* size our progress bar to be five ascents long, one high */
-	gtk_widget_set_size_request (item->progress, ascent * 5, ascent / 2);
+	/* size our progress bar to be five ascents long */
+	gtk_widget_set_size_request (item->progress, ascent * 5, -1);
 
 	gtk_box_pack_end (GTK_BOX (hbox), item->progress, FALSE, TRUE, 0);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]