Re: CVS-1-27 compile error explained

[Bill Moss <bmoss clemson edu>]

Nathan, the patch took care of the deprecated gnome function but 
returning panel-applet/Makefile.am to its original form, still leads to 
warnings regarding the syntaz: _( ). See below. In eggtrayicon.c, 
gtkcellrendererprogress.c, and gtkcellview.c, I find

#define _(x) x

By adding this to

menu-info.c
NMWirelessApplet.c
NMWirelessAppletOtherNetworkDialog.c

the compile warnings are removed.

Removing -DGNOME_DISABLE_DEPRECATED from Makefile.am had taken care of 
this issue before as well as the deprecated function.

Compile warnings:
NMWirelessApplet.c: In function `nmwa_update_state':
NMWirelessApplet.c:306: warning: implicit declaration of function `_'
NMWirelessApplet.c:306: warning: passing arg 1 of `g_strdup' makes 
pointer from integer without a cast
NMWirelessApplet.c:311: warning: passing arg 1 of `g_strdup' makes 
pointer from integer without a cast
NMWirelessApplet.c:316: warning: passing arg 1 of `g_strdup' makes 
pointer from integer without a cast
NMWirelessApplet.c:325: warning: passing arg 1 of `g_strdup' makes 
pointer from integer without a cast
NMWirelessApplet.c:339: warning: passing arg 1 of `g_strdup_printf' 
makes pointer from integer without a cast
NMWirelessApplet.c:343: warning: passing arg 1 of `g_strdup' makes 
pointer from integer without a cast
NMWirelessApplet.c:348: warning: passing arg 1 of `g_strdup' makes 
pointer from integer without a cast
NMWirelessApplet.c:353: warning: passing arg 1 of `g_strdup' makes 
pointer from integer without a cast
NMWirelessApplet.c:358: warning: passing arg 1 of `g_strdup' makes 
pointer from integer without a cast
NMWirelessApplet.c: In function `nmwa_menu_add_custom_essid_item':
NMWirelessApplet.c:681: warning: passing arg 1 of `gtk_label_new' makes 
pointer from integer without a cast
NMWirelessApplet.c: In function `nmwa_menu_add_create_network_item':
NMWirelessApplet.c:702: warning: passing arg 1 of `gtk_label_new' makes 
pointer from integer without a cast
NMWirelessApplet.c: In function `nmwa_menu_add_devices':
NMWirelessApplet.c:812: warning: passing arg 2 of 
`nmwa_menu_add_text_item' makes pointer from integer without a cast
NMWirelessApplet.c: In function `nmwa_populate_menu':
NMWirelessApplet.c:930: warning: passing arg 2 of 
`nmwa_menu_add_text_item' makes pointer from integer without a cast


Nathan Fredrickson wrote:

> On Sat, 2005-29-01 at 17:38 -0500, Dan Williams wrote:
>  
>
> > Well, I decided to try not to use deprecated functions, and since a number 
> > of the gnome guys here at work have been trying to get rid of libgnomeui 
> > (for good reason), it seems this one has gone away.  I'll have to ask 
> > around what the replacement for it is.
> >    
>
> The replacement is gtk_window_set_default_icon_from_file().  This was
> the panel-applet's only dependency on libgnomeui, so the #include can be
> removed too.  Patch attached.
>
> The only remaining dependency on libgnomeui is gnome-password-dialog in
> info-daemon/NetworkManagerInfoVPN.c, but that's not deprecated yet.
>
>  

--
Bill Moss
Professor, Mathematical Sciences
Clemson University