Re: CVS-2-7



CVS-2-2: NMWirelessApplet.c used the following code to find the active network and its strength

       if (    applet->active_device
&& (applet->active_device->type == DEVICE_TYPE_WIRELESS_ETHERNET))
       {
               GSList *list;
for (list = applet->active_device->networks; list; list = list->next)
               {
WirelessNetwork *network = (WirelessNetwork *) list->data;

                       if (network->active)
                       {
strength = CLAMP ((int) network->strength, 0, 100);
                               active_network = network;
                       }
               }

/* Fall back to old strength if current strength is invalid */
       /*      if (strength <= 0) */
                       strength = applet->active_device->strength;
       }

CVS-2-7: NMWirelessApplet.c has replaced the above with code that only finds the strength of the active_device but not the active network. Should the active_device struct be expanded to include essid or should the loop that finds the active network be restored?

      if (    applet->active_device
&& (applet->active_device->type == DEVICE_TYPE_WIRELESS_ETHERNET)) strength = CLAMP ((int)applet->active_device->strength, 0, 100);

--
Bill Moss
Professor, Mathematical Sciences
Clemson University




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]