-------- Original Message --------
Subject: Re: Nemiver updates: fix warnings, small UI enhancements, etc.
From: Dodji Seketeli <dodji seketeli org>
Date: Wed, January 07, 2015 9:20 am
To: <shane shaneharper net>
Cc: nemiver-list gnome org
Hello Shane,
Sorry for not having seen your message earlier. It was being held into
the moderation queue because you didn't subscribe to the mailing-list
before posting, and of course, the email notification I got from the
mailing list management system flew under my radar :-(
But I am seeing it now, and I am very happy about what I am seeing.
I am replying below to some interesting parts of your message so please
keep reading. I have CC-ed the mailing address nemiver-list gnome org
so please keep that into the CC list when you reply.
<shane shaneharper net> a écrit:
> I've pushed some "small" changes to a Nemiver fork I made on github
> (https://github.com/shaneharper/nemiver).
Whoah, thank you for that.
> Here is a summary of the commit log:
> Don't list "<built-in>" in Open Source File window
> Polish code
> Open Source window: Double-click/Enter opens file
> Correct spelling in comments and log messages.
> "polish" test code (minor update)
> Improve layout of Set Breakpoint dialog
> UI selection widgets expand to use available space
> Add .gitignore
> Fix glade 3 warnings
> Fix compiler error and warnings (clang v3.4)
>
> I hope these changes could be of use to others.
I have looked briefly at some of your patches and think they are very
good. There are only some nits here and there about things like
differences between your coding convention and the one of the rest of
the project.
If you are open to the idea of amending your changes toward the comments
I could make regarding those nits, (or even if you like me to amend the
code if you don't have time) I would be very happy to do a proper review
of each of the commits in your master branch on github and post it here.
Please tell me how you feel about it.
> Nemiver has helped me debug code and I've found the Nemiver source
> code to be in very good shape!
I am glad to hear that. Thank you for taking the time to actually write
code to enhance Nemiver!
Cheers,
--
Dodji