Re: Build fails on OS X 10.9

[Dodji Seketeli <dodji seketeli org>]

Juan Rafael García Blanco <juanrgar gmail com> a écrit:

Hello Juan Rafael,

> Here’s the big patch. This fixes compilation issues due to not-present
> tr1 headers, not-present pty.h, and other small issues that annoy
> clang++ (clang-500.2.79). I hope you find it somehow useful; I’m
> looking forward to receive any feedback from you.

Again, I am really sorry for this huge delay.


[...]

> From 95a84eec96e5c08546e0221aceace31585e523b8 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Juan=20R=2E=20Garc=C3=ADa=20Blanco?= <juanrgar gmail com>
> Date: Mon, 6 Jan 2014 17:40:00 +0100
> Subject: [PATCH] Fix tr1 and pty.h compilation issues
>
>       * configure.ac: Check for tr1/unordered_map, tr1/memory
>       and tr1/tuple, and their boost::tr1 counterparts.
>       Check for pty.h, util.h and libutil.h.
>       * src/common/nmv-log-stream.cc: Replace checks on compiler
>       defined macros with checks for required headers; in this
>       case tr1/unordered_map and boost/tr1/unordered_map.hpp.
>       * src/dbgengine/nmv-dbg-common.h: Check whether tr1/memory
>       or boost/tr1/memory.hpp is available and use accordingly.
>       * src/dbgengine/nmv-var-list-walker.cc (SafePtrCmp::operator()):
>       Compare method const-correctness.
>       * src/dbgengine/nmv-var-walker.cc (SafePtrCmp::operator()):
>       Compare method const-correctness.
>       * src/langs/nmv-cpp-ast.h: Replace checks on compiler
>       defined macros with checks for required headers; in this
>       case tr1/memory and boost/tr1/memory.hpp.
>       Rearrange various class definitions to make the compiler
>       aware of the class hierarchy ahead of forward-declaring
>       shared_ptr typedefs.
>       * src/persp/dbgperspective/nmv-find-text-dialog.h: Use
>       SafePtr, ObjectRef and ObjectUnref from nemiver::common.
>       * src/uicommon/nmv-terminal.cc: Check whether tr1/tuple or
>       boost/tr1/tuple.hpp is available and use accordingly.
>       Replace checks on platform defined macros with checks for
>       required headers; in this case pty.h, util.h and libutil.h.
>       * src/common/nmv-proc-utils.cc: Replace checks on
>       platform defined macros with checks for required headers;
>       in this case pty.h, util.h and libutil.h.

I have read the patch and it looks good to me.

It builds on my Fedora Rawhide GNU/Linux distribution, but I haven't
tested it on the *BSDs for instance.  I think it should work, but if it
doesn't, I guess we'll just fix what's needed.

I am thus applying this patch to the master branch of our repository.

Thank you very much.


-- 
                Dodji