Re: [PATCH 3/3] 730243 Port to vte-2.91 API (was Review of patch #730243 - Port to vte-2.91)

[Dodji Seketeli <dodji seketeli org>]

Debarshi Ray <rishi is lostca se> a écrit:

> On Tue, Jul 08, 2014 at 09:31:43AM +0200, Dodji Seketeli wrote:
> > Ah, the issue here is that the typedef-ed shorthand was for a SafePtr on
> > GObject.  Here we have a SafePtr on VtePty.
>
> I have not run it past the compiler, but from my reading of the code the
> typedef should work with any void* that is a GObject and VtePty is
> one.

Right.  But then it'd need some explicit casting down the road.  E.g

 vte_terminal_set_pty (vte, pty.get());

I'd have to cast the result of pty.get() into a VtePty*, and things like
that.

Generally speaking, I prefer the *SafePtr to keep the type of things as
much as possible.  Sometimes when it's not really possible I just give
up :-)

Cheers.

-- 
                Dodji