Re: [PATCH 3/3] 730243 Port to vte-2.91 API (was Review of patch #730243 - Port to vte-2.91)

[Dodji Seketeli <dodji seketeli org>]

Debarshi Ray <rishi is lostca se> a écrit:

> Hey Dodji,
>
> On Mon, Jul 07, 2014 at 10:01:12PM +0200, Dodji Seketeli wrote:
> > diff --git a/configure.ac b/configure.ac
> > index db99afd..8b1f93f 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -353,7 +353,7 @@ dnl library dependencies for the nemiver common UI module
> >  DEP_UICOMMON=" gtkmm-3.0 >= $LIBGTKMM_VERSION \
> >                 gtk+-3.0 >= $LIBGTK_VERSION \
> >                 gtksourceviewmm-3.0 >= $LIBGTKSOURCEVIEWMM_VERSION \
> > -               vte-2.90 >= $LIBVTE_VERSION"
> > +               vte-2.91 >= $LIBVTE_VERSION"
>
> Yes, we can change LIBVTE_VERSION too. I did not change it because changing
> the name of the library from vte-2.90 to vte-2.91 was enough to enforce what
> we want. However, it might be more understandable if we bumped LIBVTE_VERSION
> too. Whatever you want. :)

OK, let's leave it at that for now then :-)

> > -        vte_terminal_set_pty (vte, master_pty);
> > +        GError *err = 0;
> > +        VtePty *p = vte_pty_new_foreign_sync (master_pty, 0, &err);
> > +        GErrorSafePtr error (err);
> > +        SafePtr<VtePty, RefGObjectNative, UnrefGObjectNative> pty (p);
>
> What about using the typedef-ed shorthand instead of the expanded type
> name?

Ah, the issue here is that the typedef-ed shorthand was for a SafePtr on
GObject.  Here we have a SafePtr on VtePty.  I can add a new shorthand
for SafePtr on VtePty too and commit that instead.

Thanks!

-- 
                Dodji