Re: [PATCH] Port to gtkmm 3.0 and gtksourceviewmm 3.0

[Dodji Seketeli <dodji seketeli org>]

Kalev Lember <kalevlember gmail com> a écrit:

> From: Kalev Lember <kalev smartlink ee>
>
> 	* configure.ac: Require gtkmm-3.0, gtksourceviewmm-3.0,
> 	gtk+-3.0, and vte-2.90. gtkhex still needs porting to GTK+ 3;
> 	require gtkhex-2.90 to avoid pulling in the gtk2-only version.

[...]

> 	* src/persp/dbgperspective/nmv-find-text-dialog.cc: Adapt
> 	includes and using namespace directive for gtksourceviewmm
> 	renames.

[...]

Thank you for the patch update.  I have applied, tested, and commit it
to the master branch.


Kalev Lember <kalevlember gmail com> a écrit:

> If gtkhex isn't ported to gtk3 in time for next Nemiver release, it
> might even make sense to completely disable memoryview for the
> release.  I strongly suspect that we would not only need gtkhex
> changes, but also changes on Nemiver's memoryview side. And if these
> changes haven't landed for the release, building that version of
> Nemiver against a future version gtkhex 3 wouldn't work anyway.

Agreed.

One other think we could do is to keep releasing the gtk2-branch (as I
did for 0.8.2) until we have gtkhex ported to gtk3.  Sigh.  It would be
really nice if someone could step up to work on this gtkhex/gtk3 work
:-)


In any case, thank you very much for what you are doing.

>> It seems to me that renaming SourceView into View gives a too general
>> name to this type as we have have several types of views in Nemiver.
>> But I guess we can deal with this later (if needed) by introducing a
>> namespace "source" here or something.  Let's go with your change for
>> now then.
>
> That's just the result of doing batch renaming. I can easily change it
> back to SourceView (and with renaming it back we can avoid some needless
> code churn in the changeset).

Yeah.  I was just mentioning this in passing.  I don't feel strongly
about it.  If the renaming back appears to be needed at some point, I
think it will be easy to do.

Thanks!

-- 
		Dodji