Hello,
You can find attached two new patches: the first one remove the unused
status views: command, log, and target output, and the second one is
the layout manager updated from your first review.
Sorry for taking so long to update my patch.
This two patches are based on the gtk2-branch. I will update my gtk3
branch early next week.
>> + m_priv->dbg_perspective->get_terminal_view_widget ()
>> + .set_size_request (width, height);
>
>Why not using set_default_size instead of set_size_request?
Because this method only exists for a Gtk::Window
> Do you want to prevent the user from shrinking the terminal view widget?
It's the opposite, I want to allow the user to shrink the terminal view widget.
>> +#ifdef WITH_MEMORYVIEW
>> + m_priv->dbg_perspective->get_memory_view_widget ()
>> + .set_size_request (width);
>> +#endif // WITH_MEMORYVIEW
>
>Also, I don't understand why you need to set_size_request just for the
>terminal and memory view widgets and not for the other view widgets.
I don't know why, but when you add the terminal widget to a
Gdl::DockItem, the item takes all the vertical place (at least 700px
on my screen) and we cannot shrink it. The consequence is you cannot
see the sourceview widget.
With a set_size_request the widget become shrinkable.
I know that it is a dirty hack but it's working.
The same happens for the memory view, but not for all the other status widgets.
I edited my comment hoping the new one is more clear.
>> -libdbgperspectiveplugin_la_SOURCES=$(sources) $(memoryview_sources)
>> +libdbgperspectiveplugin_la_SOURCES=$(sources) $(memoryview_sources) \
>> +$(dynamiclayout_sources)
>> libdbgperspectiveplugin_la_LDFLAGS= -module -avoid-version -Wl,--as-needed
>> libdbgperspectiveplugin_la_LIBADD= \
>> @NEMIVERDBGPERSP_LIBS@ \
>> @@ -93,4 +108,3 @@ INCLUDES=@NEMIVERDBGPERSP_CFLAGS@ -DENABLE_NLS=1 -DDATADIR=\"${datadir}\" \
>> -I$(abs_top_srcdir)/src/workbench \
>> -I$(abs_top_srcdir)/src/persp \
>> -I$(abs_top_srcdir)/src/dbgperspective
>
>The removal of this -I options from the INCLUDE variable is not
>mentioned in the ChangeLog.
There is no removal of -I options. The '-' is not the sign that the
line is removed here, it is just the option -I to specifies an include
directory.
By the way this time you shouldn't find any missing space between
method's name and the opening parenthesis. I check the patch through
regex to find every occurrence of it.
Fabien Parent
Attachment:
0001-Remove-unused-status-widgets.patch
Description: Binary data
Attachment:
0002-New-Layout-Manager-and-3-additionals-new-layouts.patch
Description: Binary data