Re: disassembly-flavor support

[Dodji Seketeli <dodji seketeli org>]

Hello Fabien,

Thank you for this patch set.  The two patches are looks good to me.  I
just have a few nit comments about the first one.

>     * data/schemas/gconf/nemiver-dbgperspective.schemas: Add configuration key
>     * data/schemas/gsettings/org.nemiver.gschema.xml: Likewise
>     * src/confmgr/nmv-conf-keys.h: Likewise
>     * src/confmgr/nmv-gconf-keys-defs.cc: Likewise
>     * src/confmgr/nmv-gsettings-keys-defs.cc: Likewise
>     * src/dbgengine/nmv-gdb-engine.cc
>     (GDBEngine::Priv::launch_gdb_and_set_args): set the disassembly flavor
>     (GDBEngine::Priv::read_default_config): read the disassembly flavor from
>     the configuration.
>     (GDBEngine::Priv::on_conf_key_changed_signal): change the disassembly flavor
>     in case of change in the configuration.

[...]

> 
> diff --git a/data/schemas/gconf/nemiver-dbgperspective.schemas b/data/schemas/gconf/nemiver-dbgperspective.schemas
> index b5fdc2e..e5413c1 100644
> --- a/data/schemas/gconf/nemiver-dbgperspective.schemas
> +++ b/data/schemas/gconf/nemiver-dbgperspective.schemas

[...]

> +        <long>Can be either att or intel. Apply only for the x86 family CPU.</long>

Please remove the dot at the end of the sentence.

[...]

> diff --git a/data/schemas/gsettings/org.nemiver.gschema.xml b/data/schemas/gsettings/org.nemiver.gschema.xml
> index 836da13..821ce48 100644
> --- a/data/schemas/gsettings/org.nemiver.gschema.xml
> +++ b/data/schemas/gsettings/org.nemiver.gschema.xml

[...]

> +      <description>Can be either att or intel. Apply only for the x86 family CPU.</description>

Likewise.

[...]

> 	* src/persp/dbgperspective/nmv-preferences-dialog.cc
> 	(PreferencesDialog::Priv::on_asm_flavor_changed_signal): Update
> 	the disassembly flavor in the configuration.
> 	(PreferencesDialog::Priv::update_asm_flavor_key): Likewise
> 	(PreferencesDialog::Priv::on_reload_files_toggled_signal): Initialize
> 	new widgets.
> 	(PreferencesDialog::Priv::update_reload_files_keys): Update combobox
> 	from the configuration.
> 	* src/persp/dbgperspective/ui/preferencesdialog.ui: New frame for
> 	the disassembly flavor setting.

This second patch is OK.  Fell free to commit it (or I'll do it) when
the previous patch in the set is committed.

Thank you for this work.

Happy debugging.

-- 
		Dodji