Re: Hello ! It's been a long time ! - patch ready (almost) for pop up issue :)

[Dodji Seketeli <dodji seketeli org>]

Hello Seemanta,

Le dim. 23 mai 2010 à 00:31:19 (+0530), Seemanta Dutta a écrit:
> Thanks for reviewing my code.

It was a pleasure.

> I apologize for missing to follow the proper
> coding guidelines.

No problem :-)

> I have amended my earlier patch with these
> new fixes. So this patch is the entire fix, and is not just the corrections
> you mentioned.

Great, thanks.

I have committed your patch and pushed it to master:
http://git.gnome.org/browse/nemiver/commit/?id=5748

I have slightly edited the commit log and the following hunks:

> +bool
> +DBGPerspective::agree_to_shutdown ()
> +{
> +    LOG_DD ("In Veto function");

I replaced this by LOG_FUNCTION_SCOPE_NORMA_DD;

It's a magic macro that logs the name of the function when it's
entered _and_ when it's left. Very handy.


> +    if (debugger ()->is_attached_to_target ()) {
> +	UString message;
> +        message.printf (_("There is a program being currently debugged. " \
> +                          "Do you really want to exit from the debugger?"));
> +        if (nemiver::ui_utils::ask_yes_no_question (message) == \
> +            Gtk::RESPONSE_YES) {

I have removed the "\" at the end of the lines there, as they are not
useful.

I guess you can now close the bug
https://bugzilla.gnome.org/show_bug.cgi?id=553217 with a little
comment pointing to the commit that fixes it.

Thank you for your contribution.

Cheers.

        Dodji