[no subject]



> diff --git a/src/common/nmv-ustring.h b/src/common/nmv-ustring.h
> index bb98e87..eca1a6f 100644
> --- a/src/common/nmv-ustring.h
> +++ b/src/common/nmv-ustring.h
> @@ -50,7 +50,7 @@ public:
>      UString (const char *a_cstr, long a_len=-1) ;
>      UString (const unsigned char *a_cstr, long a_len=-1) ;
>      UString (const Glib::ustring &an_other_string) ;
> -    UString (const string &an_other_string) ;
> +    explicit UString (const string &an_other_string) ;


Now that the UString is not doing any character set conversion anymore, is there
a strong reason to keep this constructor explicit ?

> --- a/src/dbgengine/nmv-gdb-engine.cc
> +++ b/src/dbgengine/nmv-gdb-engine.cc
> @@ -529,11 +529,11 @@ public:

[snip]

> -    var.reset (new IDebugger::Variable (var_name));
> +    var.reset (new IDebugger::Variable (UString (var_name)));

See, not having the constructor I talked about above would save us from doing
this change. This applies to many more changes in that patch.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]