Re: Use of inline in nautilus

[Alexander Larsson <alexl redhat com>]

On Thu, 2010-03-11 at 13:23 +0000, Padraig O'Briain wrote:
> On 03/11/10 11:22 AM, Alexander Larsson wrote:
> > On Wed, 2010-03-10 at 09:00 +0000, Padraig O'Briain wrote:
> >    
> >> The use of inline for the functions
> >> nautilus_navigation_window_is_in_temporary_navigation_bar and
> >> nautilus_navigation_window_is_in_temporary_search_bar
> >>
> >> causes a build problem when building nautilus 2.29.90 with the Sun
> >> compiler instead of gcc.
> >>
> >> How critical is the use of inline to the performance of the
> invocation
> >> of these functions?
> >>      
> > Not critical at all. Please commit a fix.
> >
> >    
> I have attached a patch.
> 
> I have not committed a patch since the move to git and do not feel 
> confident to start with this one.

Ok, i pushed it.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl redhat com            alexander larsson gmail com 
He's a hate-fuelled hunchbacked dog-catcher on the wrong side of the law. 
She's a bloodthirsty wisecracking schoolgirl trying to make a difference in a 
man's world. They fight crime!