Re: Use of inline in nautilus

["Padraig O'Briain" <Padraig Obriain Sun COM>]

On 03/11/10 11:22 AM, Alexander Larsson wrote:
> On Wed, 2010-03-10 at 09:00 +0000, Padraig O'Briain wrote:
>    
> > The use of inline for the functions
> > nautilus_navigation_window_is_in_temporary_navigation_bar and
> > nautilus_navigation_window_is_in_temporary_search_bar
> >
> > causes a build problem when building nautilus 2.29.90 with the Sun
> > compiler instead of gcc.
> >
> > How critical is the use of inline to the performance of the invocation
> > of these functions?
> >      
> Not critical at all. Please commit a fix.
>
>    
I have attached a patch.

I have not committed a patch since the move to git and do not feel 
confident to start with this one.

Padraig

--- clean/nautilus-2.29.90/src/nautilus-navigation-window.h	2010-02-09 14:50:06.000000000 +0000
+++ nautilus-2.29.90/src/nautilus-navigation-window.h	2010-03-11 12:29:30.112028043 +0000
@@ -109,9 +109,9 @@
 void     nautilus_navigation_window_split_view_off       (NautilusNavigationWindow *window);
 gboolean nautilus_navigation_window_split_view_showing   (NautilusNavigationWindow *window);
 
-inline gboolean nautilus_navigation_window_is_in_temporary_navigation_bar (GtkWidget *widget,
+gboolean nautilus_navigation_window_is_in_temporary_navigation_bar (GtkWidget *widget,
 				NautilusNavigationWindow *window);
-inline gboolean nautilus_navigation_window_is_in_temporary_search_bar (GtkWidget *widget,
+gboolean nautilus_navigation_window_is_in_temporary_search_bar (GtkWidget *widget,
 			    NautilusNavigationWindow *window);
 
 #endif
--- clean/nautilus-2.29.90/src/nautilus-navigation-window.c	2010-02-09 14:50:06.000000000 +0000
+++ nautilus-2.29.90/src/nautilus-navigation-window.c	2010-03-11 12:56:46.306792590 +0000
@@ -286,7 +286,7 @@
 	}
 }
 
-inline gboolean
+gboolean
 nautilus_navigation_window_is_in_temporary_navigation_bar (GtkWidget *widget,
 				NautilusNavigationWindow *window)
 {
@@ -302,7 +302,7 @@
 	return is_in_any;
 }
 
-inline gboolean
+gboolean
 nautilus_navigation_window_is_in_temporary_search_bar (GtkWidget *widget,
 			    NautilusNavigationWindow *window)
 {