Re: Bug 332078 - Search button should be a toggle button

[Alexander Larsson <alexl redhat com>]

On Tue, 2009-11-24 at 19:05 +0100, Jango wrote:
> Hi!
> 
> The patch is updated... only one question left!
> 
> greetings Stefan
> 
> Nikos Verschore<nikosverschore>  wrote:
> "
> fix ctrl-l and code style
> 
> I've fixed the ctrl-l issue. So now you will get the temporary location bar
> when searching. Also the issues in style are fixed (c-commentary instead of c++
> commentary,...)
> 
> About the ctrl-f: we can disable the toggle for ctrl-f. So if you press ctrl-f
> in the main screen, you get the search bar. If you press ctrl-f again, it will
> focus the search bar. (Something like firefox is doing). We leave everything
> else as toggle (so search button and search menu item stays toggle). If you
> only want to use your keyboard and want to leave the search mode, you can use
> the ctrl-l key.
> Sounds good?

Yeah, this seems good. I commited your patch (without the GO button) and
implemented the ctrl-f behaviour. Also, i added the entry icon to
activate the search.