Re: Bug 332078 - Search button should be a toggle button

[Jango <j 4 gmx at>]

Hi!

The patch is updated... only one question left!

greetings Stefan

Nikos Verschore<nikosverschore>  wrote:
"
fix ctrl-l and code style

I've fixed the ctrl-l issue. So now you will get the temporary location bar
when searching. Also the issues in style are fixed (c-commentary instead of c++
commentary,...)

About the ctrl-f: we can disable the toggle for ctrl-f. So if you press ctrl-f
in the main screen, you get the search bar. If you press ctrl-f again, it will
focus the search bar. (Something like firefox is doing). We leave everything
else as toggle (so search button and search menu item stays toggle). If you
only want to use your keyboard and want to leave the search mode, you can use
the ctrl-l key.
Sounds good?
"



On 11/17/2009 01:00 PM, Alexander Larsson wrote:
> On Thu, 2009-10-22 at 14:13 +0200, Jango wrote:
>    
> > Hello!
> >
> > Nikos removed the search "Go" button and made a new bug report for the
> > "Go" button.
> > https://bugzilla.gnome.org/show_bug.cgi?id=598256
> >      
> The location entry version is commited now btw.
>
>    
> > This bug-patch is now ready for review.
> > We have already tested a lot - there should be no problem any more!
> >      
> I commented on it. Please ping me when there is an updated patch.
>
>
>