Re: Patch to support "F" fallback of XDS DND

On Mon, Jun 15, 2009 at 04:30:08PM +0200, Alexander Larsson wrote:
> I'm not sure why you changed the APIs to use GString. I don't think that
> really helps, it just means we have to duplicate the data in various
> places. I'd prefer to add a length argument to the functions you made
> accept a GString.
> Also, it seems like we're allocating memory for the whole file before
> saving. Thats gonna be kinda bad for large files. Also, do we really
> pass all that data as a single x message?
> Minor nits: There is a bunch of missing spaces before parenthesis in
> function calls.

Thank you for taking the time to evaluate the patch. These are some
good questions and suggestions. I'll do my best to address them and
then come back with an improved patch.

James Dietrich

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]