Re: gio, gvfs and nautilus fixes



On Tue, 2008-02-26 at 00:12 -0500, David Zeuthen wrote:
> On Mon, 2008-02-25 at 12:54 -0500, David Zeuthen wrote:
> > > I cleaned up the completion code a bit to do less magic string uri
> > > handling and instead use GFile apis.
> > 
> > It's a lot more simple now.. but you broke this important use-case
> > 
> >  $ gvfs-ls <tab>
> >  file:///            sftp://hook.local/
> >  $ gvfs-ls s<tab>
> > 
> > and it should complete to sftp://hook.local/
> > 
> > Also, there's no completion on ./ or ~/. Typically ./ is used to
> > complete on files in $CWD as completion on the empty string will give
> > you the user visible mounts (which is a design choice). So some of the
> > magic handling needs to be added back...
> 
> Attached is a patch that adds back the old completion code (but with
> some coding style fixes; hopefully I got it right). So I really don't
> think it can be much simpler than this... one thing the code needs to
> do. and that the generic GFile handling can't / shouldn't do, is to
> print the names in the same form as the user enters it... so e.g. the
> input

I solved this in a different way and added support to escape handling
etc (i.e. files with space).




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]