Re: bug 463616: patch for review



hi yann,

Am Freitag, den 15.02.2008, 11:43 +0100 schrieb Yann Simon:
> Yesterday was saint Valentin.
> I am in love with nautilus, so I am proposing a patch found in
> gnome-love bugs.

heh, cool. which exact bug do you refer to? is there already a bug
number available for it? :)

> This is my very first attempt to propose a patch to gnome. Sorry for
> nautilus... :)
> Comments are also welcomed.

that's a huge patch and i have to admit i haven't understood the purpose
of it (but i'm not a coder so i don't understand a lot of stuff :-P ).
and right now GNOME is under string freeze (because of the upcoming 2.22
release in three weeks) so this probably has to wait for a few weeks
before it could be committed.
did you change any strings, or did you just rearrange them?

> The bug is not a complicated one. The purpose is to make the life easier
> for the translators.
> I just had to re-arrange comments in static declarations. Indeed, it is
> not very interesting and I won't become hacker of the year for this. ;)
> 
> I still have one question:
> in src/file-manager/fm-directory-view.c, the result looks like this:
> 
>     /* translators: this is used to indicate that a file doesn't contain
> anything */
>   /* label, accelerator */       N_("_Empty File"), NULL,
> 
> Do the translators see the 2 previous comments, or only one?
> If they see only one, we have to change this declaration.

hmm, good question. if you want to, you can find out yourself by running
"intltool-update --pot" in the po directory and taking a look in the
resulting nautilus.pot file yourself. :)

thanks for your work,
andre

-- 
 mailto:ak-47 gmx net | failed
 http://www.iomc.de/  | http://blogs.gnome.org/aklapper

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]