Re: [rfc][patch] Add optional PackageKit hook to install new applications



On Tue, 2008-12-09 at 12:36 +0000, Richard Hughes wrote:
> On Tue, 2008-12-09 at 12:00 +0100, Alexander Larsson wrote:
> > Not really. Just let it fall through and the activation will be
> > destroyed. No need to keep it around paused.
> 
> Fair enough.
> 
> > I think you can just save (ref) the NautilusFile objects and some extra
> > info, then after the install start over with
> > nautilus_mime_activate_files(). 
> 
> Something like the attached (v.5)?

Did you actually test this?
There was all sort of issued I had to fix to make it do anything at all,
and then I don't have a recent enought PackageKit to make it work so i
had to hack up checking for that (we don't actually get an error from
dbus-glib, it just frees our data without calling the notifier). 

However, I commited something I believe works. Can you try it and see if
it actually installs something?

I also cleaned up the messages a bit so that they show what type it is,
and doesn't try to look for apps for files of unknown types.

During testing I noticed that this feature isn't as useful as it could
be, because many mime types inherit from text/plain which generally has
a handler, so they will open in gedit, not getting this dialog. Maybe we
should additionally have a "search for applications" in the open with
menu like someone proposed.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]