Re: Nautilus sidebar width and more

[Stefano Teso <stefano teso gmail com>]

Hi,

> [1] - Looks pretty ok, except I don't like the (FALSE ==
> open_in_new_window) idiom. Just do if (!foo) or if (foo) if its a
> boolean value. Also, it would be nicer if the code for activation was
> shared between the menu activation and row_activated_callback instead of
> duplicated.

Okay, I'll take care of those issues soon.

> [2] - Got some screenshots to show the difference?

Of course. Take a look at

http://bugzilla.gnome.org/show_bug.cgi?id=415695

I've attached two screenshots. The point is that the frame's shadow is
asymmetrical to the percieved sidebar's position -- that's because the
vertical resize bar doesn't have an outline, making the distinction
between view content and container widgets hard to see.

> In general we prefer to have patches on the mailing list (sometimes
> pointers to bugzilla to avoid having them forgotten). There is just way
> to much traffic in bugzilla for people to have time to read it all, so
> patches there are easily missed.

I see. So here's some other patches I posted to bugzilla in the
meantime.

[1] http://bugzilla.gnome.org/show_bug.cgi?id=416810
[2] http://bugzilla.gnome.org/show_bug.cgi?id=416806
[3] http://bugzilla.gnome.org/show_bug.cgi?id=417193

> >   * Would there be any objections in switching from a ToggleButton to a
> > ComboBox implementation for the side panels selection menu in
> > nautilus-side-pane.c?
> 
> Got any screenshots on how that would look, in various themes?
> (Including those with appears-as-list for comboboxes)

I'll attach screenshots later.

> >   * I'm primarily interested in catching a selection changed signal from
> > within nautilus_window_info_report_selection_changed () to update the
> > information sidebar contents accordingly. The problem I'm having is that
> > of accessing the information sidebar when I only have a NautilusWindow
> > at hand... Would this need complex code refactoring? If so, do you have
> > any advice about it?
> 
> Why would you need that? The information sidebar can just connect to the
> selection_changed signal.

Ooops! Of course you're right.

Thanks for your time.

----
Stefano