Re: [PATCH] Add functions for looking up drive/volume for file, use it in FMDirectoryView+FMPropertiesWindow

On Thu, 2007-01-11 at 20:52 +0100, Christian Neumair wrote:
> Am Donnerstag, den 11.01.2007, 10:57 +0100 schrieb Alexander Larsson:
> > This patch seems to add unmount/mount/eject operations to the menus
> > whenever you're displaying a mountpoint (doing this by comparing uris
> > with all mountpoints). Do we really want unmount operations for /
> > and /tmp (if thats e.g. a tmpfs mount)?
> You are right, but I'm not sure how we should deal with it. Does
> hard-coding various paths really make sense? At least for / and /tmp
> this is correct, but we can't predict admin policy and disc layout. 
> A possible solution might be to add an _is_user_mountable() helper for
> GnomeVFSDrive/Volume, and only display the extra items if it returns
> true for the enclosing drive.

I don't think _user_ adds much, and we might also want to split it to
is_mountable and is_unmountable. I'm not sure such a split its needed,
but it feels wrong to call is_mountable on / to determine if we should
show an unmount operation.

> Some brainstorming when we could return TRUE:
>  * Nonlocal drives/volumes
>  * Paths known to HAL where "volumee.ignore" is FALSE
>  * Paths in /etc/fstab where "user" attribute is provided

I'm not sure how gnome-mount works really, but there might be way with
HAL to detect wheter gnome-umount would work too. Should ask davidz.

> There have also been various proposals for an extra location widget that
> allows to unmount/eject unmountable/ejectable volumes. What do you think
> about this?

I don't like that at all. The extra location bar is meant for "special"
locations (virtual folders and whatnot), and it doesn't imho make sense
to show it for almost every folder, wasting space and generally just
acting like an extra almost empty toolbar.

 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a world-famous Amish dog-catcher looking for 'the Big One.' She's a 
brilliant wisecracking snake charmer fleeing from a Satanic cult. They fight 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]