Re: [PATCH] Add functions for looking up drive/volume for file, use it in FMDirectoryView+FMPropertiesWindow

Am Donnerstag, den 11.01.2007, 10:57 +0100 schrieb Alexander Larsson:
> This patch seems to add unmount/mount/eject operations to the menus
> whenever you're displaying a mountpoint (doing this by comparing uris
> with all mountpoints). Do we really want unmount operations for /
> and /tmp (if thats e.g. a tmpfs mount)?

You are right, but I'm not sure how we should deal with it. Does
hard-coding various paths really make sense? At least for / and /tmp
this is correct, but we can't predict admin policy and disc layout. 

A possible solution might be to add an _is_user_mountable() helper for
GnomeVFSDrive/Volume, and only display the extra items if it returns
true for the enclosing drive.

Some brainstorming when we could return TRUE:

 * Nonlocal drives/volumes
 * Paths known to HAL where "volumee.ignore" is FALSE
 * Paths in /etc/fstab where "user" attribute is provided

> Also, for unmount/eject, doesn't
> it make more sense to have that availible wherever you are inside e.g.
> a
> cdrom, and not only at the toplevel?

Sounds like a good idea.

There have also been various proposals for an extra location widget that
allows to unmount/eject unmountable/ejectable volumes. What do you think
about this?

Christian Neumair <chris gnome-de org>

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]