Re: Trash directory on removable media - Bug 138058



On Mon, 2007-02-05 at 22:35 -0500, Jesse Stockall wrote:
> On 2/5/07, Alexander Larsson <alexl redhat com> wrote:
> >
> > You should ref volume/drive over delete callback to make sure it doesn't
> > go away due to other reasons while showing the dialog.
> >
> 
> Done

This wasn't what i meant. You need to ref the volume when putting it in
the NautilusUnmountCallback, and then unref it in delete_callback when
its been used. That way we're sure its kept alive while deleting the
trash dir.

Also, some local functions needed to be made static.

I fixed this and commited.

> Do you think this warrants a gconf option to disable the prompt?

Nah.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a fast talking guerilla inventor searching for his wife's true killer. 
She's a mentally unstable gold-digging detective with a knack for trouble. 
They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]