Re: Trash directory on removable media - Bug 138058

[Alexander Larsson <alexl redhat com>]

On Sat, 2007-02-03 at 07:01 -0500, Jesse Stockall wrote:
> Thanks for taking the time to comment, this one should be easier to read.

Looks good. A few comments:

Still missing spaces in a few places like:

+gchar* 
+get_trash_uri_for_volume(GnomeVFSVolume *volume)
and
+	if (gnome_vfs_volume_handles_trash(volume)) {

+	uri = 0;
Use NULL here, not 0

get_trash_uri_for_volume(GnomeVFSVolume *volume):
This function leaks vol_uri if there is no trash dir directory.

delete_callback():
The callback owns debuting_uris, so you must free it.

You should ref volume/drive over delete callback to make sure it doesn't
go away due to other reasons while showing the dialog.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a fiendish shark-wrestling romance novelist with a mysterious suitcase 
handcuffed to his arm. She's a hard-bitten paranoid widow with the power to 
see death. They fight crime!