Re: [patch] symlink filename i18n

[Alexander Larsson <alexl redhat com>]

On Mon, 2007-04-23 at 20:33 +0900, Takao Fujiwara - Tokyo S/W Center
wrote:
> 
> Alexander Larsson wrote:
> > On Mon, 2007-04-23 at 17:29 +0900, Takao Fujiwara - Tokyo S/W Center
> > wrote:
> > 
> >>Sorry, I havn't get this.
> >>
> >>
> >>>I don't understand this. You say:
> >>>
> >>>The updated patch means if G_BROKEN_FILENAMES is defined, we use
> >>>g_locale_to_utf8() instead of g_filename_to_utf8().
> >>
> >>This means g_locale_to_utf8() doesn't use g_utf8_validate() internally and we expect it's not UTF-8 encoding.
> > 
> > 
> > What does this mean? Can you provide a little more detail. 
> > For your information, g_filename_to_utf8 does not use g_utf8_validate
> > internally.
> 
> OK, I mean:
> 
> g_filename_to_utf8() uses g_utf8_validate() internally below.
> 
> gchar*
> g_filename_to_utf8 (const gchar *opsysstring,
>                      gssize       len,
>                      gsize       *bytes_read,
>                      gsize       *bytes_written,
>                      GError     **error)
> {
>    const gchar *charset;
> 
>    if (g_utf8_validate (opsysstring, -1, NULL))
>       return strdup_len (opsysstring, len, bytes_read, bytes_written, error);
>    if (get_filename_charset (&charset))
>      return strdup_len (opsysstring, len, bytes_read, bytes_written, error);
>    else
>      return g_convert (opsysstring, len,
>                        "UTF-8", charset, bytes_read, bytes_written, error);
> }

That looks weird. What version of glib is that. Mine looks like this:

gchar*
g_filename_to_utf8 (const gchar *opsysstring, 
		    gssize       len,           
		    gsize       *bytes_read,   
		    gsize       *bytes_written,
		    GError     **error)
{
  const gchar *charset;

  if (get_filename_charset (&charset))
    return strdup_len (opsysstring, len, bytes_read, bytes_written, error);
  else
    return g_convert (opsysstring, len, 
		      "UTF-8", charset, bytes_read, bytes_written, error);
}



=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an all-American ninja cowboy who hides his scarred face behind a mask. 
She's a psychotic hip-hop hooker with someone else's memories. They fight 
crime!