Re: [patch] symlink filename i18n

[Takao Fujiwara - Tokyo S/W Center <Takao Fujiwara Sun COM>]

Sorry, I havn't get this.

> I don't understand this. You say:
>
> The updated patch means if G_BROKEN_FILENAMES is defined, we use
> g_locale_to_utf8() instead of g_filename_to_utf8().

This means g_locale_to_utf8() doesn't use g_utf8_validate() internally and we expect it's not UTF-8 encoding.



Alexander Larsson wrote:
> On Mon, 2007-01-15 at 11:25 +0900, Takao Fujiwara - Tokyo S/W Center
> wrote:
> 
>>Hi,
>>
>>Could you review the patch to enable none UTF-8 symlinks?
>>http://bugzilla.gnome.org/show_bug.cgi?id=331379
> 
> 
> I don't understand this. You say:
> 
> The updated patch means if G_BROKEN_FILENAMES is defined, we use
> g_locale_to_utf8() instead of g_filename_to_utf8().
> 
> But g_filename_to_utf8() already uses the locale encoding for filenames
> if G_BROKEN_FILENAMES is set. In fact, thats why we call
> g_filename_to_utf8(). 
> 
> Furthermore G_BROKEN_FILENAMES is a bit deprecated, and the
> g_filename_to_utf8() code now also handles G_FILENAME_ENCODING which
> lets you specify an explicit list of encodings to use for filenames.
> 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>  Alexander Larsson                                            Red Hat, Inc 
>                    alexl redhat com    alla lysator liu se 
> He's a war-weary flyboy inventor fleeing from a secret government programme. 
> She's a warm-hearted insomniac safe cracker with someone else's memories. They 
> fight crime! 
> 
>