Re: fm_list_model_get_value()

[Alexander Larsson <alexl redhat com>]

On Fri, 2006-10-06 at 20:55 +0000, Adalbert Dawid wrote:
> Hello list,
> 
> I created a profile [1] of resizing GtkTreeView's columns (for about
> 10 seconds) in nautilus' list view (see [2] for further details). Federico
> had a look at the profile and found out [3] that 
> 
> "In Nautilus, fm_list_model_get_value() spends a good amount of time
> (11.5%) re-fetching icons for the files.  It should do this only once when
> it first finds the files, and then just re-use the icons until the icon
> theme changes (or the file changes, of course)."

It does look like its doing a fair amount of work. Its not trivial to
fix though, as a lot of things change what icon we use, so caching it is
complex (need to figure out when to invalidate the cache).

Anyone interested in optimization could take a look at it.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a sword-wielding Catholic Green Beret with no name. She's a cynical mute 
Valkyrie with a song in her heart and a spring in her step. They fight crime!