Re: [Fwd: [PATCH] Replaced popt with GOption API]
- From: "martin wehner" <martin wehner gmail com>
- To: "Philip Van Hoof" <spam pvanhoof be>
- Cc: nautilus-list gnome org, pvanhoof gnome org
- Subject: Re: [Fwd: [PATCH] Replaced popt with GOption API]
- Date: Wed, 29 Mar 2006 22:33:53 +0200
On 3/27/06, Philip Van Hoof <spam pvanhoof be> wrote:
> You can find a patch attached to this bug that will replace the popt
> stuff with the newer GOption API:
>
> http://bugzilla.gnome.org/show_bug.cgi?id=336065
Thanks - it looks good in general, but there's a new string in there
("[URI...]"), so we can't commit it for gnome-2.14 in its current form
(and we haven't branched yet). There's also a combined
declaration/initialization (**remaining), which is styleguide
violation.
For the context name we'd probably want something with newlines at the
start as the documentation suggests, so that it shows up in a new
line. The description from the desktop file would be appropriate I
think.
Btw, nautilus-connect-server-dialog does use popt too now, so if you
feel inclined to completely purge it from nautilus...
Martin
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]