Re: [PATCH] New folder loses focus

[Alexander Larsson <alexl redhat com>]

On Sun, 2006-02-19 at 21:01 +0000, Nelson Benítez wrote:
> Alexander Larsson wrote:
> > On Sun, 2006-02-12 at 23:49 +0000, Nelson Benítez wrote:
> > 
> >>I have attached a patch for "Bug 326581 – New folder loses focus", the
> >>bugzilla page[1] has the details.
> >>
> >>[1] http://bugzilla.gnome.org/show_bug.cgi?id=326581
> > 
> > 
> > The way the rename failure/success is gotten to the list view is a bit
> > strange. I think you should just add a callback to fm_rename_file() that
> > always gets called when the rename operation finished, with an argument
> > that says whether is succeeded or not. This way there is no need for an
> 
> I tried this way and and made a new patch that I'm attaching to this
> mail, and imho the result is more complicated code than the signal
> approach, also see my comment in bugzilla[1].

Thats a very strange approach to callbacks, the normal way is to pass
two arguments, a function pointer and a gpointer user_data. Anyway,
while looking into this further I noticed a more serious problem which
was partly affecting this. We don't send rows_reordered on the tree
model when a file is renamed! I fixed this, and cleaned up your patch
and commited it. (On rename we changed from select renamed row to
scroll-to-row with the reorder fix, btw).

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a lounge-singing flyboy shaman with acid for blood. She's a strong-willed 
kleptomaniac Valkyrie from a secret island of warrior women. They fight crime!