Re: [PATCH] New folder loses focus

[Alexander Larsson <alexl redhat com>]

On Sun, 2006-02-12 at 23:49 +0000, Nelson Benítez wrote:
> I have attached a patch for "Bug 326581 – New folder loses focus", the
> bugzilla page[1] has the details.
> 
> [1] http://bugzilla.gnome.org/show_bug.cgi?id=326581

The way the rename failure/success is gotten to the list view is a bit
strange. I think you should just add a callback to fm_rename_file() that
always gets called when the rename operation finished, with an argument
that says whether is succeeded or not. This way there is no need for an
extra signal, nor do you have to watch the file_changed signal like
that.

Also, make sure it correctly handles if the rename operation is
cancelled. It doesn't look like your patch does that.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an oversexed voodoo cat burglar possessed of the uncanny powers of an 
insect. She's a scantily clad gypsy journalist who can talk to animals. They 
fight crime!