Re: [PATCH] Bug 380060 – Use cairo to create the rounded corners for icon captions

[Alexander Larsson <alexl redhat com>]

On Tue, 2006-12-05 at 22:46 -0800, Gene Z. Ragan wrote:
> Comrades,
> 
> This patch removes the code to mask and composite the label selection 
> corners with a bitmap
> and replaces it with Cairo based routines.
> 
> I think it is handling the normal and mask cases properly.  Please let 
> me now if I missed something.

I replaced the cairo_clip()+cairo_paint() with a single cairo_fill(), as
that seemed more natural, but otherwise it looks good, so I commited it.

I think the mask code might be wrong though. The old code rendered the
stuff as normal, but thresholded the alpha so that anything < 0.5 in
alpha became zero. This is needed because we're drawing to a Bitmap that
is used as the mask for the pixmap when used as a dnd icon.
I'm not sure how to do this right with cairo...

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a scrappy guitar-strumming messiah who must take medication to keep him 
sane. She's a blind tempestuous widow with the power to see death. They fight 
crime!