[PATCH] Bug 45953 =?windows-1252?Q?=96_Need_to_delete_po?= =?windows-1252?Q?sition_metadata_for_rm-ed_files?=



This is a partial fix for metadata removal not occurring when files are removed using rm. nautilus-monitor was only scheduling a file remove and not removing the associated metadata as well. This patch handled that case. It is now possible to do the following test case:

touch foo
rm foo
touch foo2
rm foo

foo appear in a position on the desktop and then be removed. foo2 will then take the previous location of foo. The new foo will then appear below foo2. Release Nautilus will cause foo2 and foo to collide as the old foo metadata was never removed.

The issues with volume ordering and removable volume location collisions are still unresolved.

Thanks!

Gene


Index: libnautilus-private/nautilus-monitor.c
===================================================================
RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-monitor.c,v
retrieving revision 1.24
diff -p -u -r1.24 nautilus-monitor.c
--- libnautilus-private/nautilus-monitor.c	19 Oct 2006 14:31:33 -0000	1.24
+++ libnautilus-private/nautilus-monitor.c	7 Dec 2006 07:15:48 -0000
@@ -108,6 +108,7 @@ monitor_notify_cb (GnomeVFSMonitorHandle
 		nautilus_file_changes_queue_file_changed (info_uri);
 		break;
 	case GNOME_VFS_MONITOR_EVENT_DELETED:
+		nautilus_file_changes_queue_schedule_metadata_remove (info_uri);
 		nautilus_file_changes_queue_file_removed (info_uri);
 		break;
 	case GNOME_VFS_MONITOR_EVENT_CREATED:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]