Re: [PATCH] Bug #336590 (.hidden files being symlinks)

[Alexander Larsson <alexl redhat com>]

On Sun, 2006-08-06 at 10:39 +0200, Sebastian Kapfer wrote:
> Dear nautilus-list readers,
> 
> in the bug [1], I attached a patch yesterday, and Christian suggested
> discussing it here.  The issue basically is that Nautilus
> ignores .hidden files which are symlinks (to valid regular text files).
> 
> The fix is a one-liner [2].  I did not notice any further problems.
> 
> BTW, I do not understand the rationale behind the "flags" field in
> GnomeVFSFileInfo.  There's already a flag which indicates a symlink
> "redirection", why is a symlink still being reported as a separate file
> type?  Is this just for preserving the UNIX stat interface?

Its a stat vs lstat thing. I'm commiting the following fix:

Index: libnautilus-private/nautilus-directory-async.c
===================================================================
RCS file: /cvs/gnome/nautilus/libnautilus-private/nautilus-directory-async.c,v
retrieving revision 1.224
diff -u -p -r1.224 nautilus-directory-async.c
--- libnautilus-private/nautilus-directory-async.c      4 Aug 2006 21:50:25 -0000       1.224
+++ libnautilus-private/nautilus-directory-async.c      8 Aug 2006 14:12:20 -0000
@@ -1932,7 +1932,7 @@ read_dot_hidden_file (NautilusDirectory 
        if (gnome_vfs_get_file_info_uri (
                dot_hidden_vfs_uri,
                file_info, 
-               GNOME_VFS_FILE_INFO_DEFAULT) != GNOME_VFS_OK) {
+               GNOME_VFS_FILE_INFO_FOLLOW_LINKS) != GNOME_VFS_OK) {
                gnome_vfs_uri_unref (dot_hidden_vfs_uri);
                gnome_vfs_file_info_unref (file_info);
                return;


=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a deeply religious guitar-strumming cat burglar who knows the secret of 
the alien invasion. She's a transdimensional foul-mouthed wrestler from Mars. 
They fight crime!