[PATCH] Bug #336590 (.hidden files being symlinks)

Dear nautilus-list readers,

in the bug [1], I attached a patch yesterday, and Christian suggested
discussing it here.  The issue basically is that Nautilus
ignores .hidden files which are symlinks (to valid regular text files).

The fix is a one-liner [2].  I did not notice any further problems.

BTW, I do not understand the rationale behind the "flags" field in
GnomeVFSFileInfo.  There's already a flag which indicates a symlink
"redirection", why is a symlink still being reported as a separate file
type?  Is this just for preserving the UNIX stat interface?

Best Regards,

[1] http://bugzilla.gnome.org/show_bug.cgi?id=336590

[2] diff -NrU5
--- nautilus-orig/libnautilus-private/nautilus-directory-async.c
2006-04-18 18:54:31.000000000 +0200
+++ nautilus-p/libnautilus-private/nautilus-directory-async.c	2006-08-05
21:18:20.403196250 +0200
@@ -1939,11 +1939,12 @@
 		gnome_vfs_file_info_unref (file_info);
 	file_ok = (file_info->valid_fields & GNOME_VFS_FILE_INFO_FIELDS_TYPE)
-		(file_info->type == GNOME_VFS_FILE_TYPE_REGULAR);
+		(file_info->type == GNOME_VFS_FILE_TYPE_REGULAR ||
+		 file_info->type == GNOME_VFS_FILE_TYPE_SYMBOLIC_LINK);
 	gnome_vfs_file_info_unref (file_info);
 	if (!file_ok) {
 		gnome_vfs_uri_unref (dot_hidden_vfs_uri);

Best Regards,  | Hi! I'm a .signature virus. Copy me into
 Sebastian     | your ~/.signature to help me spread!

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]