Re: [PATCH] Wrap earlier in horizontal icon container layout

[Alexander Larsson <alexl redhat com>]

On Thu, 2005-09-29 at 12:12 +0200, Christian Neumair wrote:
> Am Montag, den 26.09.2005, 11:31 +0200 schrieb Alexander Larsson:
> > On Tue, 2005-09-20 at 18:29 +0200, Christian Neumair wrote:
> > > Am Dienstag, den 20.09.2005, 18:16 +0200 schrieb Christian Neumair:
> > > > Am Montag, den 19.09.2005, 16:05 +0200 schrieb Alexander Larsson:
> > > > > On Sun, 2005-09-11 at 00:47 +0200, Christian Neumair wrote:
> > > > > > The proposed attached patch fixes bug 313025 [1] by ensuring a margin of
> > > > > > 8 on the right side of the icons.
> > > > > > 
> > > > > > [1] http://bugzilla.gnome.org/show_bug.cgi?id=313025
> > > > > 
> > > > > Is this really the right fix?
> > > > > It seems like what the patch adds is the guarantee that there will
> > > > > always be an empty area of 8 pixels to the right of all icons,
> > > > 
> > > > Indeed.
> > > > 
> > > > > whereas the bug seems to be that the icons actually go outside the right edge.
> > > > 
> > > > No. The patch complains that scrolling starts if the
> > > > window_width-edge_of_rightmost_icon \in [0;ICON_PAD_RIGHT].
> > > 
> > > "The patch" as of "The bug reporter". We used to add ICON_PAD_RIGHT to
> > > the right edge of the actual icon allocation before determining the
> > > scroll adjustment.
> > > This patch ensures that the horizontal size of the window can be reduced
> > > until the right edge of the window "hits" the right edge of the
> > > rightmost icon (plus a fuzzy px, I guess that's from the AA drawing).
> > 
> > This looks better, in almost all cases currently we get far to much
> > whitespace on the right.
> > 
> > Please commit. Also, remove the CONTAINER_PAD_RIGHT define.
> 
> Attaching a new proposed patch. The last one only fixed the issue for
> the text above icon container layout.
> 
> Note that wrapping still happens very early if all items in a directory
> are very tall (i.e. 2 character filenames).

Looks good. please commit.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a scarfaced coffee-fuelled stage actor with a winning smile and a way 
with the ladies. She's a supernatural mutant lawyer on the trail of a serial 
killer. They fight crime!